Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
drivers/intel/pmx_mux: Remove redundant declaration
Change-Id: Ie64b267ac01afa9774105e1ab8a7c18021726ff3 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/intel/pmc_mux/chip.h M src/soc/intel/tigerlake/pmc.c 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/41871/1
diff --git a/src/drivers/intel/pmc_mux/chip.h b/src/drivers/intel/pmc_mux/chip.h index f73a070..dcca2a3 100644 --- a/src/drivers/intel/pmc_mux/chip.h +++ b/src/drivers/intel/pmc_mux/chip.h @@ -3,8 +3,6 @@ #ifndef __DRIVERS_INTEL_PMC_MUX_H__ #define __DRIVERS_INTEL_PMC_MUX_H__
-extern struct chip_operations drivers_intel_pmc_mux_ops; - struct drivers_intel_pmc_mux_config { };
diff --git a/src/soc/intel/tigerlake/pmc.c b/src/soc/intel/tigerlake/pmc.c index 84a18e3..8afa412 100644 --- a/src/soc/intel/tigerlake/pmc.c +++ b/src/soc/intel/tigerlake/pmc.c @@ -124,6 +124,9 @@ dev_path(dev)); }
+/* FIXME: Rewrite loop below without this. */ +extern struct chip_operations drivers_intel_pmc_mux_ops; + /* By default, TGL uses the PMC MUX for all ports, so port_number is unused */ const struct device *soc_get_pmc_mux_device(int port_number) {
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41871/2/src/soc/intel/tigerlake/pmc... File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/41871/2/src/soc/intel/tigerlake/pmc... PS2, Line 129: /* FIXME: Rewrite loop below without this. */ Another case for CB:35456?
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
drivers/intel/pmx_mux: Remove redundant declaration
Change-Id: Ie64b267ac01afa9774105e1ab8a7c18021726ff3 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41871 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/pmc_mux/chip.h M src/soc/intel/tigerlake/pmc.c 2 files changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/drivers/intel/pmc_mux/chip.h b/src/drivers/intel/pmc_mux/chip.h index f73a070..dcca2a3 100644 --- a/src/drivers/intel/pmc_mux/chip.h +++ b/src/drivers/intel/pmc_mux/chip.h @@ -3,8 +3,6 @@ #ifndef __DRIVERS_INTEL_PMC_MUX_H__ #define __DRIVERS_INTEL_PMC_MUX_H__
-extern struct chip_operations drivers_intel_pmc_mux_ops; - struct drivers_intel_pmc_mux_config { };
diff --git a/src/soc/intel/tigerlake/pmc.c b/src/soc/intel/tigerlake/pmc.c index 8fcbe50..f2f8a06 100644 --- a/src/soc/intel/tigerlake/pmc.c +++ b/src/soc/intel/tigerlake/pmc.c @@ -126,6 +126,9 @@ dev_path(dev)); }
+/* FIXME: Rewrite loop below without this. */ +extern struct chip_operations drivers_intel_pmc_mux_ops; + /* By default, TGL uses the PMC MUX for all ports, so port_number is unused */ const struct device *soc_get_pmc_mux_device(int port_number) {
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41871/2/src/soc/intel/tigerlake/pmc... File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/41871/2/src/soc/intel/tigerlake/pmc... PS2, Line 129: /* FIXME: Rewrite loop below without this. */
Another case for CB:35456?
You bet! I've been meaning to get around to reviewing that. I'll try to take another look soon, as Duncan pointed out, it would simplify a lot of things like this.
-
Duncan Laurie (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)