Attention is currently required from: Brandon Weeks, Federico Amedeo Izzo, Felix Singer, Joel Linn, Paul Menzel.
Angel Pons has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81595/comment/a1d6f5e9_681dac85?usp... :
PS9, Line 10: Memory: DDR5-4800 SODIMM (max 16 GB)
It only has 1 DIMM slot, however I get an error during complication when DIMM_MAX is set to 1: https […]
OK, I wouldn't worry about the Kconfig. But at least SPD mapping should be updated.
File src/mainboard/cwwk/adl/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81595/comment/7d09a524_d0c3544b?usp... :
PS10, Line 23: [1] = { .addr_dimm[0] = 0x52, },
If the board only has one DIMM slot, then only one of these lines is needed. As to which, To figure out which, I'd suggest `i2cdetect -y $SMBUS_INDEX` where `SMBUS_INDEX` is the number that appears in `i2cdetect -l`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81595?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice9174d95c10afc6a22ddd15fb3be4fa38d329be
Gerrit-Change-Number: 81595
Gerrit-PatchSet: 10
Gerrit-Owner: Brandon Weeks
bweeks@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Joel Linn
jl_coreboot@conductive.de
Gerrit-CC: Matthew Garrett
mjgarrett59@googlemail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Brandon Weeks
bweeks@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-Attention: Joel Linn
jl_coreboot@conductive.de
Gerrit-Comment-Date: Tue, 21 May 2024 23:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Brandon Weeks
bweeks@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com