Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49064 )
Change subject: nb/intel/sandybridge: Replace memset with initializer ......................................................................
nb/intel/sandybridge: Replace memset with initializer
There's no need to use `memset` here.
Change-Id: I0478bc3ff25b75bf0b554aa83ead6a63fcbd975c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/49064/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 3c60a9f..61663b8 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1137,11 +1137,9 @@ static void fine_tune_rcven_pi(ramctr_timing *ctrl, int channel, int slotrank, int *upperA) { int rcven_delta; - int statistics[NUM_LANES][51]; + int statistics[NUM_LANES][51] = {0}; int lane, i;
- memset(statistics, 0, sizeof(statistics)); - for (rcven_delta = -25; rcven_delta <= 25; rcven_delta++) {
FOR_ALL_LANES {
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49064 )
Change subject: nb/intel/sandybridge: Replace memset with initializer ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49064 )
Change subject: nb/intel/sandybridge: Replace memset with initializer ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49064 )
Change subject: nb/intel/sandybridge: Replace memset with initializer ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49064 )
Change subject: nb/intel/sandybridge: Replace memset with initializer ......................................................................
nb/intel/sandybridge: Replace memset with initializer
There's no need to use `memset` here.
Change-Id: I0478bc3ff25b75bf0b554aa83ead6a63fcbd975c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49064 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 3c60a9f..61663b8 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1137,11 +1137,9 @@ static void fine_tune_rcven_pi(ramctr_timing *ctrl, int channel, int slotrank, int *upperA) { int rcven_delta; - int statistics[NUM_LANES][51]; + int statistics[NUM_LANES][51] = {0}; int lane, i;
- memset(statistics, 0, sizeof(statistics)); - for (rcven_delta = -25; rcven_delta <= 25; rcven_delta++) {
FOR_ALL_LANES {
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)