Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/27397 )
Change subject: riscv: add trampoline in MBR block to support boot mode 1 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/27397/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27397/3//COMMIT_MSG@11 PS3, Line 11: issues.
The trampoline part contains the location of the bootblock, so if the change is split, the jump woul […]
But how is the stack alignment related to the position of the bootblock? I haven't looked at these details of the RISC-V port in a while, and I don't know it, so I think others reading this commit message won't know that either, and it should be explained in the commit message.
About splitting the commit: If you do the alignment change first, then you don't need to add a jump instruction and change it later.
-
Jonathan Neuschäfer (Code Review)