Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44121 )
Change subject: nb/intel/sandybridge: Refactor `get_pcie_bar` ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sandy... PS4, Line 50: return 0; It might be personal preference but I think return 1 on error is more common.
https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sandy... PS4, Line 143: decode_pcie_bar if this return an 'error' it should probably die given the pci mmconfig accesses done pretty much everywhere
-
Arthur Heymans (Code Review)