Attention is currently required from: Wonkyu Kim.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55187 )
Change subject: cpu/x86/lapic: Add lapic_update32() helper
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/55187/comment/83b9330d_0131d1c0
PS3, Line 35: LAPIC_DELIVERY_MODE_EXTINT);
Docs say DELIVERY_MODE_EXTINT should only appear on one LAPIC.
LVT_REMOTE_IRR and SEND_PENDING are read-only bits?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57c5d85d3098f9d59f26f427fe16829e4e769194
Gerrit-Change-Number: 55187
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Sun, 06 Jun 2021 12:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment