Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62294 )
Change subject: mb, soc: Add the SPD_CACHE_ENABLE
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
True, we need to pass the FSPM_UPD structure rather soc config structure alone. if you have time constraint, please go with current approach and I will make it proper in coming days.
We're going to clean up the brask issue and we will need this CL before the end of the this week. Will you be able to make the change before that?
I'm not sure if able to pick this before EOW. If you have priority, please go ahead and I will pick this work after CL lands.
If so, i think we can wait for it đ
Please don't wait for me, just to be at safe side đ from your work priority.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7625a00c865dc268e2a22efd71b34b40c40877b
Gerrit-Change-Number: 62294
Gerrit-PatchSet: 3
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Tue, 01 Mar 2022 06:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment