Change in coreboot[master]: HACK sc7180: bootblock/verstage/romstage need to zero bss HACK
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35896 )
Change subject: HACK sc7180: bootblock/verstage/romstage need to zero bss HACK ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35896/1/src/security/vboot/verstage... File src/security/vboot/verstage.c:
https://review.coreboot.org/c/coreboot/+/35896/1/src/security/vboot/verstage... PS1, Line 28: memset(_bss, 0, (_ebss-_bss));
This is the wrong place for this hack.
I don't doubt that, I don't even understand why this should be required, based on code in cbfs_prog_stage_load()
/* Clear area not covered by file. */ memset(&load[fsize], 0, stage.memlen - fsize);
I was looking for quick-and-dirty place to do this in verstage, similar to bootblock_soc_early_init() as a test. Doing this here allowed test to progress out of verstage and reach romstage.
-
mturney mturney (Code Review)