Attention is currently required from: Name of user not set #1002003, John Zhao, Paul Menzel, Rajmohan Mani.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63848 )
Change subject: drivers/intel/usb4: Add Type-C port device attachment check
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63848/comment/fd8bf7d2_bb769d33
PS6, Line 18: Type-C ports under DA successfully.
Sorry, I did not test. […]
The point is the behavior was erroneous before when there was a device attached (DA), but worked OK in no device attached (NDA)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/63848/comment/6c332de5_6f7216f1
PS8, Line 71: acpigen_disable_tx_gpio(power_gpio);
This GPIO was disabled on line 40 while EC reports error. […]
Ack. This right here is the Device Attached scenario, where it returns an error?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210
Gerrit-Change-Number: 63848
Gerrit-PatchSet: 8
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Name of user not set #1002003
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
jzhao80@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Name of user not set #1002003
Gerrit-Attention: John Zhao
jzhao80@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Comment-Date: Wed, 04 May 2022 18:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: John Zhao
jzhao80@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment