Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86246?usp=email )
Change subject: acpi: Zero-out MADT before filling it ......................................................................
acpi: Zero-out MADT before filling it
Otherwise flags field is pre-filled with random garbage.
Change-Id: Ie5dc0720183b8ba07561341003f28a86ffce911e Signed-off-by: Vladimir Serbinenko phcoder@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86246 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/acpi/acpi.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Jérémy Compostella: Looks good to me, approved
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index ffd9b79..8f5c09f 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -138,6 +138,8 @@ acpi_madt_t *madt = (acpi_madt_t *)header; unsigned long current = (unsigned long)madt + sizeof(acpi_madt_t);
+ memset(madt, 0, sizeof(*madt)); + if (acpi_fill_header(header, "APIC", MADT, sizeof(acpi_madt_t)) != CB_SUCCESS) return;