Matt Delco has posted comments on this change. ( https://review.coreboot.org/28068 )
Change subject: cpu/intel/common: add function to init cppc_config ......................................................................
Patch Set 4:
Why don't you put it into src/cpu/intel ? It looks like version 2 could be used on all Intel CPUs in tree.
So I made an attempt to move it under there and revised the change. The best place I could spot was under common, and while I don't like sticking it in the only source file called common_init.c I also wasn't ready to break it out into a separate file yet either. The cpu/ and soc/ subdirs appear to be operating and evolving separately (e.g., they each have different implementations to enable vmx).
I'm open to feedback on different ways to do this, though I'm also curious to see what the buildbot thinks of this attempt.