Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31468 )
Change subject: rmodule: Add support for R_X86_64_PLT32
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31468/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31468/2//COMMIT_MSG@13
PS2, Line 13: R_X86_64_PLT32
I'm not sure we should be allowing the compiler/linker to emit these relocations. Is the default truly PC-relative? And w/o plt entries its treated as a normal pc relative? I think some description is warranted because on the surface this doesn't seem appropriate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31468
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81350d2728c20ac72cc865e7ba92319858352632
Gerrit-Change-Number: 31468
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sol Boucher
solb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Feb 2019 15:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment