Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang, Zhuohao Lee.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81564?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/deku: Swap LAN device indices ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81564/comment/1656644b_2e433f88 : PS4, Line 7: Swap LAN device indices Maybe even:
Swap LAN device indices for correct MAC address
https://review.coreboot.org/c/coreboot/+/81564/comment/b191a26b_6f3d0872 : PS4, Line 9: Deku has 2 ethernet ports, due to the LAN devices indices were swapped. : So set vpd ethernet_mac0 will affect the eth1 and set vpd ethernet_mac1 will affect the eth0 from ifconfig. Maybe use:
google/deku has two Ethernet ports. Currently both get assigned the wrong MAC address due to the LAN devices indices being swapped and `vpd ethernet_mac0()` affects device `eth1` and `vpd ethernet_mac1()` affects device `eth0`.
https://review.coreboot.org/c/coreboot/+/81564/comment/7849cbad_cab4d527 : PS4, Line 12: This CL is to correct the device indices for LAN devices so ethernet_mac[0-1] in vpd can apply to the correct ethernet ports. Please use 72 characters per line.
https://review.coreboot.org/c/coreboot/+/81564/comment/9142072e_5edb58d6 : PS4, Line 12: This CL is to correct Correct