Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27727 )
Change subject: security/vboot: Enable TCPA log extension ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/27727/2/src/security/tpm/tspi/tspi.c File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/#/c/27727/2/src/security/tpm/tspi/tspi.c@181 PS2, Line 181: uint32_t tpm_extend_pcr(const char *name, int pcr, uint8_t *digest, i'd prefer "const char *name" to be the last argument, as it's only required for logging.
https://review.coreboot.org/#/c/27727/2/src/security/tpm/tspi/tspi.c@195 PS2, Line 195: printk(BIOS_ERR, "ERROR: Couldn't creat TCPA log entry\n"); create
https://review.coreboot.org/#/c/27727/2/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/27727/2/src/security/vboot/secdata_tpm.c@83 PS2, Line 83: return tpm_extend_pcr("GBB flags", pcr, buffer, size); do you want to use defines for the TCPA log entries in a public header ?
-
Patrick Rudolph (Code Review)