View Change

3 comments:

• File src/security/tpm/tspi/tspi.c:

  • Patch Set #2, Line 181: uint32_t tpm_extend_pcr(const char *name, int pcr, uint8_t *digest,

    i'd prefer "const char *name" to be the last argument, as it's only required for logging.

  • Patch Set #2, Line 195: printk(BIOS_ERR, "ERROR: Couldn't creat TCPA log entry\n");

    create

• File src/security/vboot/secdata_tpm.c:

  • Patch Set #2, Line 83: return tpm_extend_pcr("GBB flags", pcr, buffer, size);

    do you want to use defines for the TCPA log entries in a public header ?

To view, visit change 27727. To unsubscribe, or for help writing mail filters, visit settings.