Change in coreboot[master]: src/soc/intel/braswell/southcluster.c: Correct configuration of inter...
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29419 )
Change subject: src/soc/intel/braswell/southcluster.c: Correct configuration of interrupts ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 120: for(irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 152: /* Find the PIRQ that is attached to the INT_PIN this device uses */ line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 153: pirq = (ir->pcidev[device_num] >> ((new_int_pin - 1) * 4)) & 0x7; line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 159: /* Set this IRQ to level triggered since it is used by a PCI device */ line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 160: i8259_configure_irq_trigger(int_line, IRQ_LEVEL_TRIGGERED); line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 161: /* Set the Interrupt Line register in PCI config space */ line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 162: pci_write_config8(irq_dev, PCI_INTERRUPT_LINE, int_line); line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 164: /* Set the Interrupt line register as "unknown or unused" */ line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 173: new_int_pin, pin_to_str(new_int_pin)); line over 80 characters
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 284: if ( ir->pic[i] ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 284: if ( ir->pic[i] ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.... PS1, Line 284: if ( ir->pic[i] ) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)