Attention is currently required from: Mathew King, Bhanu Prakash Maiya, Ivy Jian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52181/comment/b09d0726_4bc2e0e3 PS4, Line 101: Use tabs instead of spaces here and in the below lines.
File src/mainboard/google/guybrush/variants/guybrush/variant.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/e293c8b9_3d32c7e5 PS4, Line 8: variant_fpmcu_init I think instead of adding a special function to handle the power-on, we should invest in adding a special driver for the FPMCU device that does the power sequencing as part of ACPI. It will eliminate the need for this variant function completely.
-
Furquan Shaikh (Code Review)