Attention is currently required from: Eric Lai, Felix Held, Jian Tong, Paul Menzel, Shelley Chen, Subrata Banik.
Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: drivers/spi/acpi: Add generic property list ......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83139/comment/ba96b8ec_5386e0b6?usp... : PS9, Line 8:
Please start by describing the problem.
Done
https://review.coreboot.org/c/coreboot/+/83139/comment/eb0a6bc2_f11c6695?usp... : PS9, Line 14: TEST=emerge-brox coreboot
Any commands you ran?
local build bios,and verify that the correct transfer of hid-report-addr to the touch driver.
File src/drivers/spi/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/83139/comment/fe52f5a7_ccb64f77?usp... : PS9, Line 8: #define MAX_GENERIC_PROPERTY_LIST 10
Why 10? Please elaborate in the commit.
This is a universal code. If only one attribute is defined for the vendor Goodix, in the future, if other vendors need to define multiple attributes, it cannot be met. MAX_GENERIC-PROPERTY-LIST needs to be modified, defined as 10 here, which basically meets the attribute requirements of all vendors. In the future, other projects only need to add the vendor's attributes in the devicetree without further modification.
-
Kun Liu (Code Review)