Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41815 )
Change subject: console: Update for vboot before bootblock ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41815/4/src/console/Makefile.inc File src/console/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41815/4/src/console/Makefile.inc@14 PS4, Line 14: ifneq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y) The files here should be arch-agnostic. Which parts exactly are not usable for psp-verstage? Is there a followup to look at?
https://review.coreboot.org/c/coreboot/+/41815/4/src/console/init.c File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/41815/4/src/console/init.c@72 PS4, Line 72: pci_early_bridge_init
I think there's a good argument to make for having it here. […]
We could probably change this to EARLY_PCI_BRIDGE && (ENV_BOOTBLOCK || ENV_ROMSTAGE). I don't see why we would need it called for verstage as the BARs on the secondary side PCIe device (assummed serial uart) persist across stage changes.
The entire EARLY_PCI_BRIDGE is very rarely used indeed and probably does not even work with FSP, PCIe rootports are not usable until late FSP-M from what I remember.
Like Martin said, it was used for debugging some of the first Chromebooks with mini-PCI-e serial cards, before servo and closed-case-debugging.
-
Kyösti Mälkki (Code Review)