Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Angel Pons,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/52432
to review the following change.
Change subject: Revert "libpayload/keyboard: Reset to scancode set #2 on exit" ......................................................................
Revert "libpayload/keyboard: Reset to scancode set #2 on exit"
This reverts commit 1f2b5fb20137afc897aff6304cd31682cac56282.
Reason for revert: Breaks all chromebook keyboards.
Change-Id: Ice5057ab0b764d784b172f09aeacabaa4e74f34f --- M payloads/libpayload/drivers/i8042/keyboard.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/52432/1
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index a695723..cc412ac 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -655,11 +655,6 @@ keyboard_cmd(I8042_KBCMD_DEFAULT_DIS); keyboard_drain_input();
- /* Nobody but us seems to still use scancode set #1. - So try to hand over with more modern settings. */ - set_scancode_set(2); - i8042_set_kbd_translation(false); - /* Send keyboard disconnect command */ i8042_cmd(I8042_CMD_DIS_KB);