Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38915 )
Change subject: drivers/intel/gma: Print EDID with leading instead of trailing space ......................................................................
drivers/intel/gma: Print EDID with leading instead of trailing space
This way, the block is a little indented below `EDID:` making it a little more structured for the eye.
Change-Id: I12066efefb23c5ffa8ba6b8c486cd54e142d4dc1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/drivers/intel/gma/edid.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/38915/1
diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c index cf6ea51..ca3ab32 100644 --- a/src/drivers/intel/gma/edid.c +++ b/src/drivers/intel/gma/edid.c @@ -103,7 +103,7 @@
printk (BIOS_SPEW, "EDID:\n"); for (i = 0; i < 128; i++) { - printk(BIOS_SPEW, "%02x ", edid[i]); + printk(BIOS_SPEW, " %02x", edid[i]); if ((i & 0xf) == 0xf) printk (BIOS_SPEW, "\n"); }
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38915 )
Change subject: drivers/intel/gma: Print EDID with leading instead of trailing space ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38915 )
Change subject: drivers/intel/gma: Print EDID with leading instead of trailing space ......................................................................
drivers/intel/gma: Print EDID with leading instead of trailing space
This way, the block is a little indented below `EDID:` making it a little more structured for the eye.
Change-Id: I12066efefb23c5ffa8ba6b8c486cd54e142d4dc1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38915 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/drivers/intel/gma/edid.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c index cf6ea51..ca3ab32 100644 --- a/src/drivers/intel/gma/edid.c +++ b/src/drivers/intel/gma/edid.c @@ -103,7 +103,7 @@
printk (BIOS_SPEW, "EDID:\n"); for (i = 0; i < 128; i++) { - printk(BIOS_SPEW, "%02x ", edid[i]); + printk(BIOS_SPEW, " %02x", edid[i]); if ((i & 0xf) == 0xf) printk (BIOS_SPEW, "\n"); }