Attention is currently required from: Shelley Chen, Ravi kumar, Furquan Shaikh, Paul Menzel, Julius Werner, mturney mturney.
Prasad Malisetty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib
......................................................................
Patch Set 25:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53903/comment/14004c4f_43cae11f
PS25, Line 9: Added MMIO Support
Add MMIO support
Agree, Will update the change in next release.
https://review.coreboot.org/c/coreboot/+/53903/comment/80efa7a4_b1b12cc7
PS25, Line 11: passed
is passed
Agree, Will update the change in next release.
File payloads/libpayload/drivers/pci_ops.c:
https://review.coreboot.org/c/coreboot/+/53903/comment/13e76fd7_a93a05f5
PS25, Line 2: *Copyright
Missing space.
Okay, Will update the change in next release.
https://review.coreboot.org/c/coreboot/+/53903/comment/4dd8ccbb_6fd5e11b
PS25, Line 26: */
Use SPDX header?
I will add the licence in next release.
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/53903/comment/5146ec20_eb5ee60c
PS25, Line 90:
Use tab as above.
Sure. update the change in next release
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cfb95e31b7ee984ee0c2e7586e6caeecd7deadd
Gerrit-Change-Number: 53903
Gerrit-PatchSet: 25
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 20 Jul 2021 04:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment