Attention is currently required from: Frank Wu, Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, chris wang, EricR Lai.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50212 )
Change subject: soc/amd/picasso: clean up and re-sort UPD table
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
Verified that this matches the update that will be going into the AGESA FSP code.
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/50212/comment/ad5dc03a_09d10ff5
PS6, Line 257: /* bit vector of phy, bit0=1: DP0, bit1=1: DP1, bit2=1: DP2 bit3=1: DP3 */
: uint8_t edp_physel;
Not needed for this commit, but why not turn this into a macro?
#define DP0_PHY BIT(0)
...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I655af08e2f86398d088e30d330f49e71cf7e1275
Gerrit-Change-Number: 50212
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 03:31:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment