Change in coreboot[master]: cpu/intel/car/p4: Add x86_64 support - coreboot-gerrit

5 Jul 2021


      Attention is currently required from: Nico Huber, Paul Menzel, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56021 )
Change subject: cpu/intel/car/p4: Add x86_64 support
......................................................................
Patch Set 5:
(2 comments)
File src/cpu/intel/car/p4-netburst/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/56021/comment/5645b62c_ee568bb2 
PS4, Line 363:
...
Remove the blank line as below? The indentation should help enough for readability.
Done
https://review.coreboot.org/c/coreboot/+/56021/comment/ca4929b5_463a7425 
PS4, Line 365:
...
Please add a similar comment as below.
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77516e3cd5f0d3b7442be660c005a65b00454343
Gerrit-Change-Number: 56021
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 05 Jul 2021 19:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment