Attention is currently required from: Martin L Roth, Jakub Czapiga, Arthur Heymans, Patrick Rudolph, Elyes Haouas.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62181 )
Change subject: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
......................................................................
Patch Set 8:
(1 comment)
File src/include/device/dram/ddr4.h:
https://review.coreboot.org/c/coreboot/+/62181/comment/06ccbbd1_281b520f
PS7, Line 29: SPD_DDR4_DIMM_TYPE_EXTENDED = 0x0,
SPD_DDR2_DIMM_TYPE_MASK is used here : src/device/dram/ddr2.c […]
Yeah, let's postpone this. Using register values in an internal API isn't a good
design choice, but that's how things are right now.
But maybe move this entry to the other enum. So we are reminded that there is
more to it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621
Gerrit-Change-Number: 62181
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 06 Sep 2022 10:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment