[M] Change in coreboot[main]: soc/intel/common/block: Add support for watchdog

[Subrata Banik (Code Review)]

Attention is currently required from: Jakub Czapiga, Marek Maślanka, Michał Żygowski.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )

Change subject: soc/intel/common/block: Add support for watchdog
......................................................................

Patch Set 14:

(6 comments)

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/4c4030db_22e9436d :
PS13, Line 396: rightmost_bit_offset
> The only thing that comes to mind to make the name more descriptive is to change it to `find_rightmost_set_bit_offset`

can you see if `__builtin_ctzll` is helpful for ur case? without need to implement find_rightmost_set_bit_offset?

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/494734dd_675e6f2e :
PS14, Line 408: tcobase
are we okay to go forward if tcobase is not even programmed ? like zero ?

https://review.coreboot.org/c/coreboot/+/79909/comment/01ae329d_4b1632a9 :
PS14, Line 423: tcobase
same

https://review.coreboot.org/c/coreboot/+/79909/comment/ec5b7dd3_c422ca80 :
PS14, Line 430: 0x01
can we have a macro ?

https://review.coreboot.org/c/coreboot/+/79909/comment/9b3b470e_102b7ea0 :
PS14, Line 469: acpi_soc_fill_wdat
do u have a caller of this function implemented already ?

https://review.coreboot.org/c/coreboot/+/79909/comment/fad910dc_4c6ae3ba :
PS14, Line 487: 	if (tcobase == 0) {
              : 		wdat->flags = ACPI_WDAT_FLAG_DISABLED;
              : 		return current;
              : 	}
shouldn't we return this at line 474?