Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50042 )
Change subject: soc/intel/broadwell: Drop `SPIBARx` macros
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The current situation is a mess, I known. But I'm not sure
if this doesn't make it worse. Intel has (almost?) always
documented the SPIBAR separately, even if its location was
implicitly configured relative to RCBA. Also, newer chipsets
have a separate BAR now (with mostly identical registers).
So it would seem much more future-proof to have SPIBAR macros
or functions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50042
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cd91fec92e33dbb7dfebbfd440e3db2e9b4e914
Gerrit-Change-Number: 50042
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 06 Feb 2021 16:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment