Sukumar Ghorai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78303?usp=email )
Change subject: [WIP] Revert "soc/intel/meteorlake: Hook up UPD for C1 C-state auto-demotion" ......................................................................
[WIP] Revert "soc/intel/meteorlake: Hook up UPD for C1 C-state auto-demotion"
This reverts commit bab976b85817526c8bf358c3af2d5ac410a575a1.
Change-Id: I703f49b6d5751d6de5b319fa3a91bff2ee43a934 Signed-off-by: Sukumar Ghorai sukumar.ghorai@intel.com --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/fsp_params.c 2 files changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/78303/1
diff --git a/src/soc/intel/meteorlake/chip.h b/src/soc/intel/meteorlake/chip.h index 6210406..2d56058 100644 --- a/src/soc/intel/meteorlake/chip.h +++ b/src/soc/intel/meteorlake/chip.h @@ -406,16 +406,6 @@ uint8_t lan_clk;
/* - * Enable or Disable C1 C-state Auto Demotion & un-demotion - * The algorithm looks at the behavior of the wake up tracker, how - * often it is waking up, and based on that it demote the c-state. - * Default 0. Set this to 1 in order to disable C1-state auto demotion. - * NOTE: Un-Demotion from Demoted C1 needs to be disabled when - * C1 C-state Auto Demotion is disabled. - */ - bool disable_c1_state_auto_demotion; - - /* * Enable or Disable Package C-state Demotion. * Default is set to 0. * Set this to 1 in order to disable Package C-state demotion. diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index 5ec9cf4..c1329a5 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -661,10 +661,6 @@ /* Enable the energy efficient turbo mode */ s_cfg->EnergyEfficientTurbo = 1; s_cfg->PmcLpmS0ixSubStateEnableMask = get_supported_lpm_mask(); - /* Un-Demotion from Demoted C1 need to be disable when - * C1 auto demotion is disabled */ - s_cfg->C1StateUnDemotion = !config->disable_c1_state_auto_demotion; - s_cfg->C1StateAutoDemotion = !config->disable_c1_state_auto_demotion; s_cfg->PkgCStateDemotion = !config->disable_package_c_state_demotion; s_cfg->PkgCStateUnDemotion = !config->disable_package_c_state_demotion; s_cfg->PmcV1p05PhyExtFetControlEn = 1;