Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29757 )
Change subject: soc/intel/common/dptf: Make CPU address a define ......................................................................
soc/intel/common/dptf: Make CPU address a define
In order to support using the common ACPI code on more platforms than just Apollo Lake the DPTF code needs to be told what the PCI address is for the CPU thermal device.
Change-Id: I638f2387330bbc42f64eb0fb676ee32c5df6572e Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/29757 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/apollolake/acpi/dptf.asl M src/soc/intel/common/acpi/dptf/cpu.asl 2 files changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/acpi/dptf.asl b/src/soc/intel/apollolake/acpi/dptf.asl index b9ba9c3..f34725f 100644 --- a/src/soc/intel/apollolake/acpi/dptf.asl +++ b/src/soc/intel/apollolake/acpi/dptf.asl @@ -14,6 +14,7 @@ */
#define DPTF_CPU_DEVICE TCPU +#define DPTF_CPU_ADDR 0x00000001
#ifndef DPTF_CPU_PASSIVE #define DPTF_CPU_PASSIVE 80 diff --git a/src/soc/intel/common/acpi/dptf/cpu.asl b/src/soc/intel/common/acpi/dptf/cpu.asl index c28c0cc..9414e25 100644 --- a/src/soc/intel/common/acpi/dptf/cpu.asl +++ b/src/soc/intel/common/acpi/dptf/cpu.asl @@ -23,7 +23,7 @@
Device (DPTF_CPU_DEVICE) { - Name(_ADR, 0x00000001) + Name(_ADR, DPTF_CPU_ADDR)
Method (_STA) {