Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 )
Change subject: mb/google/corsola: Initialize krabby display
......................................................................
Patch Set 8:
(3 comments)
Patchset:
PS1:
it's built pass with CB:60515. […]
Done
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/60447/comment/5321ddb0_6edb1df1
PS5, Line 97: NULL
what about putting a place holder function? then we don't need to check NULL pointers.
Done
https://review.coreboot.org/c/coreboot/+/60447/comment/3d7126c5_9177ba7e
PS5, Line 124: if (bridge->get_edid) {
: if (bridge->get_edid(i2c_bus, &edid) < 0) {
I'd rather always provide the implementation and do: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I314d5407c40429bb7bc50f36fece58e396b27548
Gerrit-Change-Number: 60447
Gerrit-PatchSet: 8
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 30 Dec 2021 08:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment