Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 )
Change subject: soc/amd/common/block/apob: Add hashed APOB support ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67301/comment/db1c388c_8993512a PS4, Line 15: chausie Can you try it on a guybrush device?
File src/soc/amd/common/block/apob/apob_cache.c:
https://review.coreboot.org/c/coreboot/+/67301/comment/e203a733_f248556b PS4, Line 57: apob_header_ptr->size + MRC_HASH_SIZE You could probably do this as a `_Static_assert` above
https://review.coreboot.org/c/coreboot/+/67301/comment/dd58bcc8_c1dc8df4 PS4, Line 195: xxh64 I wonder if coreboot has an existing has function. I know vboot has sha2*, but now sure if that's easy to use.
https://review.coreboot.org/c/coreboot/+/67301/comment/e9176f71_7ab090ed PS4, Line 214: !update_needed && You can probably skip this part since `apob_rom` will be `NULL` if `update_needed == true`
-
Raul Rangel (Code Review)