Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38998 )
Change subject: mb/intel/tglrvp: add Tiger Lake memory initialization support
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38998/5/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:
PS5:
Please separate out SoC and mainboard changes into different CLs.
https://review.coreboot.org/c/coreboot/+/38998/5/src/soc/intel/tigerlake/inc...
PS5, Line 64:
: /* Rcomp configuration information */
: struct rcomp_cfg {
: /* Rcomp Resistor */
: uint16_t rcomp_resistor;
:
: /* Rcomp Target */
: uint16_t rcomp_target[NUM_RCOMP_TARGETS];
:
: };
:
Why is this required? IIUC, based on discussions on partner bug, Rcomp values are not required to be passed in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7248862efd1dcd5a0df0e17d39b44c168caa200e
Gerrit-Change-Number: 38998
Gerrit-PatchSet: 5
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 04:39:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment