Attention is currently required from: Uwe Poeche, Andrey Petrov. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63546 )
Change subject: intel/common/block: Provide RAPL and min clock ratio switches in common ......................................................................
Patch Set 6: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63546/comment/bb9f7338_dc66c8a8 PS2, Line 7: provide config switches from APL specific
This could be formulated more clear, e.g.: […]
Done
https://review.coreboot.org/c/coreboot/+/63546/comment/e7b31104_a5822464 PS2, Line 10: APL_SKIP_SET_POWER_LIMITS
APL_SET_MIN_CLOCK_RATIO
Done
https://review.coreboot.org/c/coreboot/+/63546/comment/92ff3fa1_1020a3b5 PS2, Line 12: Therefore they moved here with other name to common/block.
Maybe 'Move them to common code instead of having them just for one SOC'
Done
https://review.coreboot.org/c/coreboot/+/63546/comment/63b95ca0_7460ced8 PS2, Line 14: mainboards mc_apl1/4/5: compare cpu clock via MSR 0x198 and RAPL : settings via MSR 0x610 before and after the change.
Maybe: […]
Done
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/63546/comment/c61250b1_b8978d0d PS2, Line 144: Some Apollo Lake mainboards do not need the Running Average Power : Limits (RAPL) algorithm for a constant power management. : Set this config option to skip the RAPL configuration.
I would rephrase this text as it is not APL specific anymore
Done