Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19558 )
Change subject: google/gru: support 800M/928M frequency for bob ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/19558/3/src/mainboard/google/gru/Kconfig File src/mainboard/google/gru/Kconfig:
Line 97
I think it might be nice to keep this option and use it for snprintf. In fa
I guess that's no
https://review.coreboot.org/#/c/19558/3/src/mainboard/google/gru/sdram_confi... File src/mainboard/google/gru/sdram_configs.c:
Line 49: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4)
Rather than duplicating the file name list for all frequencies, why not jus
Then, can the CONFIG_GRU_SDRAM_FREQ be defined by the board_id()?
e.g: I want to support the bob to run ddr 800M for rev3 board and run 928M for rev4 board.