Change in coreboot[master]: [TEST]: mb/google/dedede: Reduce PL1 and PL2 values

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: [TEST]...

Sumeet R Pawnikar (Code Review)

29 Jul 2020 29 Jul '20

11:03 p.m.

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44053 )

Change subject: [TEST]: mb/google/dedede: Reduce PL1 and PL2 values ......................................................................

[TEST]: mb/google/dedede: Reduce PL1 and PL2 values

This is test patch reduces PL1 and PL2 values.

Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 7502489..86dee2a 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -148,14 +148,14 @@ register "dptf_enable" = "1"

register "power_limits_config" = "{ - .tdp_pl1_override = 6, - .tdp_pl2_override = 20, + .tdp_pl1_override = 4, + .tdp_pl2_override = 15, }"

# Enable processor thermal control register "Device4Enable" = "1"

- register "tcc_offset" = "10" # TCC of 90C + register "tcc_offset" = "20" # TCC of 90C

# chipset_lockdown configuration # Use below format to override value in overridetree.cb if required @@ -181,13 +181,13 @@

register "controls.power_limits.pl1" = "{ .min_power = 3000, - .max_power = 6000, + .max_power = 4000, .time_window_min = 1 * MSECS_PER_SEC, .time_window_max = 1 * MSECS_PER_SEC, .granularity = 200,}" register "controls.power_limits.pl2" = "{ .min_power = 6000, - .max_power = 20000, + .max_power = 15000, .time_window_min = 1 * MSECS_PER_SEC, .time_window_max = 1 * MSECS_PER_SEC, .granularity = 1000,}"

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Sumeet R Pawnikar (Code Review)

31 Jul 31 Jul

6:56 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#2).

Change subject: mb/google/dedede: Reduce PL1 and PL2 ......................................................................

mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

6:58 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Reduce PL1 and PL2

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44053 )

Change subject: mb/google/dedede: Reduce PL1 and PL2 ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44053/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44053/2/src/mainboard/google/dedede... PS2, Line 150: register "power_limits_config" = "{ : .tdp_pl1_override = 4, : .tdp_pl2_override = 12, : }" Isn't this redundant with what's on line 182 onwards?

Sumeet R Pawnikar (Code Review)

6:59 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#3).

Change subject: mb/google/dedede: Reduce PL1 and PL2 ......................................................................

mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

1 Aug 1 Aug

1:18 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#4).

Change subject: mb/google/dedede: Reduce PL1 and PL2 ......................................................................

mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

1:58 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#5).

Change subject: mb/google/dedede: Reduce PL1 and PL2 ......................................................................

mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 5 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

2 Aug 2 Aug

10:41 p.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#6).

Change subject: [TEST] mb/google/dedede: Reduce PL1 and PL2 ......................................................................

[TEST] mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values. -- DO NOT MERGE --

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 6 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

3 Aug 3 Aug

8:20 a.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#7).

Change subject: [TEST] mb/google/dedede: Reduce PL1 and PL2 ......................................................................

[TEST] mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values. -- DO NOT MERGE --

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 7 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

11:48 p.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1 and PL2

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#8).

Change subject: [TEST] mb/google/dedede: Reduce PL1 and PL2 ......................................................................

[TEST] mb/google/dedede: Reduce PL1 and PL2

This is test patch reduces PL1 and PL2 values. -- DO NOT MERGE --

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 8 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

4 Aug 4 Aug

12:06 a.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#9).

Change subject: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC ......................................................................

[TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

This is test patch to avoid system shutdown during stress test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 9 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

5 Aug 5 Aug

4:47 a.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#10).

Change subject: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC ......................................................................

[TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

This is test patch to avoid system shutdown during stress test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 10 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

4:58 a.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44053

to look at the new patch set (#11).

Change subject: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC ......................................................................

[TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

This is test patch to avoid system shutdown during stress test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/44053/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 11 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

19 Aug 19 Aug

9:31 a.m.

New subject: Change in coreboot[master]: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC

Sumeet R Pawnikar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44053 )

Change subject: [TEST] mb/google/dedede: Reduce PL1, PL2 and TCC ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/44053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32325f2db941bbeb1566635f2cf99760982d170 Gerrit-Change-Number: 44053 Gerrit-PatchSet: 11 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1729

days inactive

1749

days old

coreboot-gerrit@coreboot.org

12 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Sumeet R Pawnikar (Code Review)