Change in coreboot[master]: soc/amd/common: Use only byte access for old GPIO

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48689 )

Change subject: soc/amd/common: Use only byte access for old GPIO
......................................................................

soc/amd/common: Use only byte access for old GPIO

Change-Id: I06ec29845d051d9b90ab6f3cfb269ad5e6b75ea8
Signed-off-by: Kyösti Mälkki 
---
M src/soc/amd/common/block/include/amdblocks/acpimmio.h
1 file changed, 0 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/48689/1

diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index ca32f23..4b80a28 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -305,31 +305,11 @@
    return read8(acpimmio_gpio_100 + reg);
 }

-static inline uint16_t gpio_100_read16(uint8_t reg)
-{
-	return read16(acpimmio_gpio_100 + reg);
-}
-
-static inline uint32_t gpio_100_read32(uint8_t reg)
-{
-	return read32(acpimmio_gpio_100 + reg);
-}
-
 static inline void gpio_100_write8(uint8_t reg, uint8_t value)
 {
    write8(acpimmio_gpio_100 + reg, value);
 }

-static inline void gpio_100_write16(uint8_t reg, uint16_t value)
-{
-	write16(acpimmio_gpio_100 + reg, value);
-}
-
-static inline void gpio_100_write32(uint8_t reg, uint32_t value)
-{
-	write32(acpimmio_gpio_100 + reg, value);
-}
-
 /* New GPIO banks configuration registers */

static inline void *gpio_ctrl_ptr(uint8_t gpio_num)

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48689 )

Change subject: soc/amd/common: Use only byte access for old GPIO
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48689 )

Change subject: soc/amd/common: Use only byte access for old GPIO
......................................................................

soc/amd/common: Use only byte access for old GPIO

Change-Id: I06ec29845d051d9b90ab6f3cfb269ad5e6b75ea8
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48689
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
---
M src/soc/amd/common/block/include/amdblocks/acpimmio.h
1 file changed, 0 insertions(+), 20 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index ca32f23..4b80a28 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -305,31 +305,11 @@
    return read8(acpimmio_gpio_100 + reg);
 }

-static inline uint16_t gpio_100_read16(uint8_t reg)
-{
-	return read16(acpimmio_gpio_100 + reg);
-}
-
-static inline uint32_t gpio_100_read32(uint8_t reg)
-{
-	return read32(acpimmio_gpio_100 + reg);
-}
-
 static inline void gpio_100_write8(uint8_t reg, uint8_t value)
 {
    write8(acpimmio_gpio_100 + reg, value);
 }

-static inline void gpio_100_write16(uint8_t reg, uint16_t value)
-{
-	write16(acpimmio_gpio_100 + reg, value);
-}
-
-static inline void gpio_100_write32(uint8_t reg, uint32_t value)
-{
-	write32(acpimmio_gpio_100 + reg, value);
-}
-
 /* New GPIO banks configuration registers */

static inline void *gpio_ctrl_ptr(uint8_t gpio_num)