Change in coreboot[master]: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

5 Nov 2020 5 Nov '20

7:37 a.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47230 )

Change subject: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource ......................................................................

mb/google/dedede/var/drawcia: Remove camera EEPROM power resource

EEPROM in the camera module does not require any specific power resources. This will ensure that no unnecessary resources are turned on while accessing the camera EEPROM.

BUG=b:167938257 TEST=Build and boot to OS in Drawlat. Ensure that the camera EEPROM is listed in the output of i2cdetect.

Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/47230/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 5942121..8bd0204 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -274,8 +274,6 @@ register "chip_name" = ""GT24C08"" register "device_type" = "INTEL_ACPI_CAMERA_NVM"

- register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC"" - register "nvm_size" = "0x0400" register "nvm_pagesize" = "1" register "nvm_readonly" = "1"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Justin TerAvest (Code Review)

5 Nov 5 Nov

6:22 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47230 )

Change subject: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Gerrit-Change-Number: 47230 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tomasz Figa tfiga@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 05 Nov 2020 18:22:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:24 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47230 )

Change subject: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Gerrit-Change-Number: 47230 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tomasz Figa tfiga@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 05 Nov 2020 18:24:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Nov 9 Nov

7:29 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47230 )

Change subject: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource ......................................................................

mb/google/dedede/var/drawcia: Remove camera EEPROM power resource

EEPROM in the camera module does not require any specific power resources. This will ensure that no unnecessary resources are turned on while accessing the camera EEPROM.

BUG=b:167938257 TEST=Build and boot to OS in Drawlat. Ensure that the camera EEPROM is listed in the output of i2cdetect.

Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47230 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 202e0f4..574ae38 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -274,8 +274,6 @@ register "chip_name" = ""GT24C08"" register "device_type" = "INTEL_ACPI_CAMERA_NVM"

- register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC"" - register "nvm_size" = "0x0400" register "nvm_pagesize" = "1" register "nvm_readonly" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/47230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Gerrit-Change-Number: 47230 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tomasz Figa tfiga@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Tomasz Figa (Code Review)

10 Nov 10 Nov

10:51 a.m.

Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47230 )

Change subject: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47230/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47230/2//COMMIT_MSG@11 PS2, Line 11: while accessing the camera EEPROM. Does this mean that the camera module design keeps the EEPROM and related I2C lines always on?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Gerrit-Change-Number: 47230 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tomasz Figa tfiga@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 10 Nov 2020 10:51:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

5:34 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47230 )

Change subject: mb/google/dedede/var/drawcia: Remove camera EEPROM power resource ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47230/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47230/2//COMMIT_MSG@11 PS2, Line 11: while accessing the camera EEPROM.

...

Does this mean that the camera module design keeps the EEPROM and related I2C lines always on?

Based on the comment here: https://issuetracker.google.com/issues/167938257#comment128 and the data sheet for TFC and LVI modules, as long as the 1.8V rail is up and WCAM_RST_L routed to XSHUTDN is asserted/low, then EEPROM is accessible.

The 1.2 V and 2.8 V rails used to enable the camera sensors and VCM are not required.

FW & SW does not have the ability to control the 1.8V rail. WCAM_RST_L is inited to '0' as part of GPIO configuration in coreboot.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iece9b3f657bf94a21cc08bf1745353575858f9b2 Gerrit-Change-Number: 47230 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tomasz Figa tfiga@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 10 Nov 2020 17:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tomasz Figa tfiga@google.com Gerrit-MessageType: comment

1478

days inactive

1483

days old

coreboot-gerrit@coreboot.org

5 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Justin TerAvest (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Tomasz Figa (Code Review)