Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: gitsoc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
gitsoc/amd/picasso: Disable MP2 FW inclusion by default
Inclusion of MP2 firmware is optional and dependent on mainboard. Set default option for including MP2 firmware in PSP directory to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I1ff7527a409d8ac7f4d30e69eafc53975b63e49b --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40680/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index c7e65fa..b58ba88 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -324,7 +324,7 @@
config PSP_LOAD_MP2_FW bool "Include MP2 blobs in PSP build" - default y + default n help Include the MP2 firmwares and configuration into the PSP build.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40680
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
soc/amd/picasso: Disable MP2 FW inclusion by default
Inclusion of MP2 firmware is optional and dependent on mainboard. Set default option for including MP2 firmware in PSP directory to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I1ff7527a409d8ac7f4d30e69eafc53975b63e49b --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40680/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig... PS2, Line 331: y n ?
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig... PS2, Line 326: bool "Include MP2 blobs in PSP build" I still think these should not be prompting the user. Mainboard should do the proper 'select'ions. That is for another patch though.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig... PS2, Line 326: bool "Include MP2 blobs in PSP build"
I still think these should not be prompting the user. Mainboard should do the proper 'select'ions. […]
Agreed. I will follow-up with removing the options from being user-visible.
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig... PS2, Line 331: y
n ?
Done
Hello build bot (Jenkins), Raul Rangel, Angel Pons, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40680
to look at the new patch set (#3).
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
soc/amd/picasso: Disable MP2 FW inclusion by default
Inclusion of MP2 firmware is optional and dependent on mainboard. Set default option for including MP2 firmware in PSP directory to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I1ff7527a409d8ac7f4d30e69eafc53975b63e49b --- M src/soc/amd/picasso/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40680/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40680/2/src/soc/amd/picasso/Kconfig... PS2, Line 326: bool "Include MP2 blobs in PSP build"
Agreed. I will follow-up with removing the options from being user-visible.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 3: Code-Review+2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40680 )
Change subject: soc/amd/picasso: Disable MP2 FW inclusion by default ......................................................................
soc/amd/picasso: Disable MP2 FW inclusion by default
Inclusion of MP2 firmware is optional and dependent on mainboard. Set default option for including MP2 firmware in PSP directory to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I1ff7527a409d8ac7f4d30e69eafc53975b63e49b Reviewed-on: https://review.coreboot.org/c/coreboot/+/40680 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index afa18bc..c9f45f1 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -330,11 +330,11 @@
config PSP_LOAD_MP2_FW bool "Include MP2 blobs in PSP build" - default y + default n help Include the MP2 firmwares and configuration into the PSP build.
- If unsure, answer 'y' + If unsure, answer 'n'
config PSP_LOAD_S0I3_FW bool "Include S0I3 blob in PSP build"
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Marshall Dawson (Code Review)