Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enables CSE update flow for hatch ......................................................................
src/soc/intel/cannonlake: Enables CSE update flow for hatch
BUG=b:111330995
Change-Id: I79232b5fdf55a1808b2b9815b462d0a0443ff675 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/mainboard/google/hatch/Kconfig M src/soc/intel/common/basecode/fw_update/Kconfig 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39227/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index c411077..2484e12 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -23,9 +23,9 @@ select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_COMETLAKE select SYSTEM_TYPE_LAPTOP - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE - select INTEL_CSE_FW_SKU_CUSTOM + select RT8168_GET_MAC_FROM_VPD if BOARD_GOOGLE_PUFF + select RT8168_SET_LED_MODE if BOARD_GOOGLE_PUFF + select INTEL_CSE_UPDATE if BOARD_GOOGLE_HATCH
if BOARD_GOOGLE_BASEBOARD_HATCH
diff --git a/src/soc/intel/common/basecode/fw_update/Kconfig b/src/soc/intel/common/basecode/fw_update/Kconfig index 2b0835a..2a24bc5 100644 --- a/src/soc/intel/common/basecode/fw_update/Kconfig +++ b/src/soc/intel/common/basecode/fw_update/Kconfig @@ -1,6 +1,7 @@ config INTEL_CSE_UPDATE bool default n + select INTEL_CSE_FW_SKU_CUSTOM
config ADD_ME_RW_BINARY bool
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enables CSE update flow for hatch ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39227/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39227/1//COMMIT_MSG@7 PS1, Line 7: Enables Please use imperative mood:
Enable CSE update flow for hatch
https://review.coreboot.org/c/coreboot/+/39227/1//COMMIT_MSG@7 PS1, Line 7: src/soc/intel/cannonlake: Enables CSE update flow for hatch Remove.
https://review.coreboot.org/c/coreboot/+/39227/1//COMMIT_MSG@8 PS1, Line 8: Please add more details to the commit message.
https://review.coreboot.org/c/coreboot/+/39227/1//COMMIT_MSG@10 PS1, Line 10: The blank line can be removed.
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39227
to look at the new patch set (#2).
Change subject: src/soc/intel/cannonlake: Enable CSE update flow for hatch ......................................................................
src/soc/intel/cannonlake: Enable CSE update flow for hatch
It enable CSE firmware update flow for hatch.
BUG=b:111330995 TEST=Verified on hatch
Change-Id: I79232b5fdf55a1808b2b9815b462d0a0443ff675 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/mainboard/google/hatch/Kconfig M src/soc/intel/cannonlake/me.c 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39227/2
Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enable CSE update flow for hatch ......................................................................
Abandoned
Sridhar Siricilla has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enable CSE update flow for hatch ......................................................................
Removed reviewer Patrick Rudolph.
Sridhar Siricilla has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enable CSE update flow for hatch ......................................................................
Removed reviewer Paul Menzel.
Sridhar Siricilla has restored this change. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enable CSE update flow for hatch ......................................................................
Restored
Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39227 )
Change subject: src/soc/intel/cannonlake: Enable CSE update flow for hatch ......................................................................
Abandoned
-
Paul Menzel (Code Review) -
Sridhar Siricilla (Code Review)