Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Paul Menzel, Tim Crawford.
Hello Krystian Hebel, Michał Żygowski, Patrick Rudolph, Sean Rhodes, Tim Crawford, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73981?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Tim Crawford, Verified-1 by build bot (Jenkins)
Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times ......................................................................
drivers/smmstore/ramstage.c: retry smmstore init up 5 times
Retry calling the SMI 5 times in case the initial write to APM did not cause SMM entry immediately.
Fixes occasional SMMSTORE initialization failure on Clevo NV4xPZ with Intel i5-1240P processor. The issue was especially evident when all logging in coreboot was disabled.
Based on SMMSTORE implementation in MrChromebox's fork of EDK2: https://github.com/MrChromebox/edk2/commit/27854bc8c5e7147f01e50404f6e5b16ff...
Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com --- M src/drivers/smmstore/ramstage.c 1 file changed, 12 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/73981/2