Attention is currently required from: Raul Rangel, Furquan Shaikh, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55136 )
Change subject: mb/google/guybrush: initialize i2c in psp_verstage
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/verstage.c:
https://review.coreboot.org/c/coreboot/+/55136/comment/bf1d3eb3_adf8eac5
PS1, Line 28: if (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)) {
: enable_aoac_devices();
: printk(BIOS_DEBUG, "Setting up i2c\n");
: i2c_soc_early_init();
: printk(BIOS_DEBUG, "i2c setup\n");
: }
I think this should be done as part of `verstage_soc_init()` and not mainboard init. […]
I thought i2c is only used for the communication with GSC so the code is specific to guybrush. For other stages it makes sense to initialize all peripherals but do we need to do so in psp_verstage?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f7b73be67a692ea7de31ae53bd111d0e4b6998c
Gerrit-Change-Number: 55136
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Jun 2021 02:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment