Attention is currently required from: Robert Chen, Nick Vaccaro, Shon Wang.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
I will review in more details tomorrow.
But here is my quick feedback.
I'm recommending to split this CL into atleast 3 CLs as below:
1. Add I2C driver for CS35L53 support.
2. Configure GPIO for vell variant.
2. Let Brya Kconfig.name to select this for vell variant and required override dt changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 02 Jan 2022 21:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment