Change in coreboot[master]: mb/google/puff: Update DPTF parameters for faffy

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

David Wu (Code Review)

8 Sep 2020 8 Sep '20

4:45 a.m.

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Update DPTF parameters for faffy ......................................................................

mb/google/puff: Update DPTF parameters for faffy

Update critical and passive policy for TSR0.

BUG=b:167477885 BRANCH=puff TEST=build and verify by thermal team

Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc --- M src/mainboard/google/hatch/variants/faffy/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45169/1

diff --git a/src/mainboard/google/hatch/variants/faffy/overridetree.cb b/src/mainboard/google/hatch/variants/faffy/overridetree.cb index c1bd1e4..a05cb9d 100644 --- a/src/mainboard/google/hatch/variants/faffy/overridetree.cb +++ b/src/mainboard/google/hatch/variants/faffy/overridetree.cb @@ -281,11 +281,11 @@ chip drivers/intel/dptf ## Passive Policy register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 95, 5000)" - register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 63, 5000)" + register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 75, 5000)"

## Critical Policy register "policies.critical[0]" = "DPTF_CRITICAL(CPU, 100, SHUTDOWN)" - register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 78, SHUTDOWN)" + register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 85, SHUTDOWN)"

## Power Limits Control # 10-15W PL1 in 200mW increments, avg over 28-32s interval

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Sam McNally (Code Review)

8 Sep 8 Sep

4:56 a.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Update DPTF parameters for faffy ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Comment-Date: Tue, 08 Sep 2020 07:56:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

7:59 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Update DPTF parameters for faffy ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45169/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45169/1//COMMIT_MSG@7 PS1, Line 7: mb/google/puff: Update DPTF parameters for faffy Increase DPTF parameters for faffy

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Sep 2020 10:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

David Wu (Code Review)

8:02 a.m.

New subject: Change in coreboot[master]: mb/google/puff: Increase DPTF parameters for faffy

Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45169

to look at the new patch set (#2).

Change subject: mb/google/puff: Increase DPTF parameters for faffy ......................................................................

mb/google/puff: Increase DPTF parameters for faffy

Update critical and passive policy for TSR0.

BUG=b:167477885 BRANCH=puff TEST=build and verify by thermal team

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45169/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

David Wu (Code Review)

8:02 a.m.

New subject: Change in coreboot[master]: mb/google/puff: Increase DPTF parameters for faffy

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Increase DPTF parameters for faffy ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45169/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45169/1//COMMIT_MSG@7 PS1, Line 7: mb/google/puff: Update DPTF parameters for faffy

...

Increase DPTF parameters for faffy

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Sep 2020 11:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

9:11 p.m.

New subject: Change in coreboot[master]: mb/google/puff: Increase DPTF parameters for faffy

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Increase DPTF parameters for faffy ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 00:11:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

9:11 p.m.

New subject: Change in coreboot[master]: mb/google/puff: Increase DPTF parameters for faffy

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Increase DPTF parameters for faffy ......................................................................

mb/google/puff: Increase DPTF parameters for faffy

Update critical and passive policy for TSR0.

BUG=b:167477885 BRANCH=puff TEST=build and verify by thermal team

Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Reviewed-on: https://review.coreboot.org/c/coreboot/+/45169 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/faffy/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved

## Power Limits Control # 10-15W PL1 in 200mW increments, avg over 28-32s interval

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

9:57 p.m.

New subject: Change in coreboot[master]: mb/google/puff: Increase DPTF parameters for faffy

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45169 )

Change subject: mb/google/puff: Increase DPTF parameters for faffy ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18353 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18352 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/18351 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18350 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/18349 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/18356 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18355 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18354

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244e1b5cacabf5b73c47b4039ae150cd17fcd0fc Gerrit-Change-Number: 45169 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 00:57:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1685

days inactive

1686

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
David Wu (Code Review)
Edward O'Callaghan (Code Review)
Paul Menzel (Code Review)
Sam McNally (Code Review)