Attention is currently required from: Wayne3 Wang, Henry Sun, Ariel Chang, Paul Menzel, Paul2 Huang, Alex1 Kao.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54529 )
Change subject: mb/google/dedede: Support Realtek audio codec ALC5682I and speaker L/R
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/dedede/variants/pirika/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/54529/comment/b59b1248_f968a66e
PS10, Line 68: probe AUDIO_AMP UNPROVISIONED
Is there an unprovisioned case? If the CBI is always provisioned with amplifier info, then this line can be removed. We did it for other variants where the amplifier info was not provisioned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8173ffbfb1a8f18978a5e35c69972d4a6d8cb04a
Gerrit-Change-Number: 54529
Gerrit-PatchSet: 10
Gerrit-Owner: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Attention: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 22:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment