Attention is currently required from: Felix Singer, Michał Żygowski.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86109?usp=email )
Change subject: ec/dasharo: Add dependancy to EC_DASHARO_EC_FLASH_SIZE ......................................................................
Patch Set 1:
(1 comment)
File src/ec/dasharo/ec/Kconfig:
https://review.coreboot.org/c/coreboot/+/86109/comment/4557b475_f850ff56?usp... : PS1, Line 9: config EC_DASHARO_EC_BAT_THRESHOLDS : depends on EC_DASHARO_EC : bool : default y : : config EC_DASHARO_EC_DGPU : depends on EC_DASHARO_EC : bool : default n : : config EC_DASHARO_EC_UPDATE : depends on EC_DASHARO_EC : bool "Update the embedded controller firmware" : default n : : config EC_DASHARO_EC_UPDATE_FILE : depends on EC_DASHARO_EC_UPDATE : string "Path to the EC update file" : default "ec.rom" : : config EC_DASHARO_EC_FLASH_SIZE : depends on EC_DASHARO_EC : hex : default 0x20000
Maybe just guard to the whole thing.
I'll leave it to Michal if he wants to change