Attention is currently required from: Anil Kumar K.
Subrata Banik has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: I was comparing ALC 711 and ALC 722 (your CL) and felt that only change between those two drivers are .version, .part_id and .class. Additionally, you can refactor the existing ALC 711 code to accommodate both codec (this will save the coding and review effort as well)
1.
``` static struct soundwire_address alc711_address = { #if CONFIG(DRIVERS_SOUNDWIRE_ALC722) .version = SOUNDWIRE_VERSION_1_2, .class = MIPI_CLASS_SDCA .part_id = MIPI_DEV_ID_REALTEK_ALC722, #elif CONFIG(DRIVERS_SOUNDWIRE_ALC711) .version = SOUNDWIRE_VERSION_1_1, .class = MIPI_CLASS_NONE .part_id = MIPI_DEV_ID_REALTEK_ALC711, #else #error "Select correct codec driver" #endif .manufacturer_id = MIPI_MFG_ID_REALTEK, }; ```
2.
``` config DRIVERS_SOUNDWIRE_ALC_BASE_7XX bool help Base code for Realtek ALC7xxx Codec Soundwire Driver.
config DRIVERS_SOUNDWIRE_ALC711 bool select DRIVERS_SOUNDWIRE_ALC_BASE_7XX Soundwire Driver for Realtek ALC711 device
config DRIVERS_SOUNDWIRE_ALC722 bool select DRIVERS_SOUNDWIRE_ALC_BASE_7XX help Soundwire Driver for Realtek ALC722 device ```
3.
``` ramstage-$(CONFIG_DRIVERS_SOUNDWIRE_ALC_BASE_7XX) += alc711.c ```