Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34843 )
Change subject: soc/intel/common: gpio_defs: set trig to disable in PAD_NC ......................................................................
soc/intel/common: gpio_defs: set trig to disable in PAD_NC
There is no need to change the default value for the RX Level/Edge Configuration parameter if the pad is not used/connected (PAD_NC)
Change-Id: Ie7eee83fba9320d52240166371fe0c757dbdce49 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/34843/1
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h index 7440952..0c52f7d 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h @@ -289,11 +289,11 @@ /* * No Connect configuration for unused pad. * Both TX and RX are disabled. RX disabling is done to avoid unnecessary - * setting of GPI_STS. + * setting of GPI_STS. RX Level/Edge Trig Configuration set to disable */ #define PAD_NC(pad, pull) \ _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(DEEP) | \ + PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | \ PAD_CFG0_TX_DISABLE | PAD_CFG0_RX_DISABLE, \ PAD_PULL(pull) | PAD_IOSSTATE(TxDRxE))
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34843 )
Change subject: soc/intel/common: gpio_defs: set trig to disable in PAD_NC ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34843 )
Change subject: soc/intel/common: gpio_defs: set trig to disable in PAD_NC ......................................................................
soc/intel/common: gpio_defs: set trig to disable in PAD_NC
There is no need to change the default value for the RX Level/Edge Configuration parameter if the pad is not used/connected (PAD_NC)
Change-Id: Ie7eee83fba9320d52240166371fe0c757dbdce49 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34843 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h index 7440952..0c52f7d 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h @@ -289,11 +289,11 @@ /* * No Connect configuration for unused pad. * Both TX and RX are disabled. RX disabling is done to avoid unnecessary - * setting of GPI_STS. + * setting of GPI_STS. RX Level/Edge Trig Configuration set to disable */ #define PAD_NC(pad, pull) \ _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(DEEP) | \ + PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_CFG0_TRIG_OFF | \ PAD_CFG0_TX_DISABLE | PAD_CFG0_RX_DISABLE, \ PAD_PULL(pull) | PAD_IOSSTATE(TxDRxE))
-
Furquan Shaikh (Code Review) -
Maxim Polyakov (Code Review)
-
Patrick Georgi (Code Review)