Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Paul Menzel, Angel Pons, Johnny Li, Shuming Chu (Shuming), Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 )
Change subject: drivers/ocp: add VPD processing framework
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/ocp/vpd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68784/comment/611dfab9_50640a14
PS2, Line 3: smm-$(C
Config VPD_SMM_SUPPORT is uploaded to CB:67092 for VPD access in SMM.
It's a bad idea if you just want boot time configuration. I suggest passing the configuration once, just like how it's done for passing the cbmemc buffer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I705bea348b1611f25ccbd798b77cfee22ec30f0f
Gerrit-Change-Number: 68784
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sun, 13 Nov 2022 10:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment