Change in coreboot[master]: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Edward O'Callaghan (Code Review)

1 Jul 2020 1 Jul '20

7:52 p.m.

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42994 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern

BUG=b:1603699358 BRANCH=none TEST=none

Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/wyvern/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/42994/1

diff --git a/src/mainboard/google/hatch/variants/wyvern/overridetree.cb b/src/mainboard/google/hatch/variants/wyvern/overridetree.cb index 55ce5ea..244e678 100644 --- a/src/mainboard/google/hatch/variants/wyvern/overridetree.cb +++ b/src/mainboard/google/hatch/variants/wyvern/overridetree.cb @@ -81,6 +81,18 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" # Type-A Port 0 register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A Port 4

+ # Bitmap for Wake Enable on USB attach/detach + register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + register "usb3_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Sam McNally (Code Review)

1 Jul 1 Jul

8:42 p.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42994 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42994/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/wyvern/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42994/1/src/mainboard/google/hatch/... PS1, Line 85: register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ These should match noibat.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-Comment-Date: Thu, 02 Jul 2020 03:42:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

9:21 p.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42994 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42994/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/wyvern/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42994/1/src/mainboard/google/hatch/... PS1, Line 85: register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \

...

These should match noibat.

USB ports need adjusting as well so leaving it to a seperate change where it can be done together in one logical change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-Comment-Date: Thu, 02 Jul 2020 04:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

9:28 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42994 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

Patch Set 1: Code-Review+2

Please CC me on the Puff-wide change for the USB ports.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-Comment-Date: Thu, 02 Jul 2020 04:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

9:42 p.m.

Hello build bot (Jenkins), Paul Fagerburg, Paul Fagerburg,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42994

to look at the new patch set (#2).

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern

V.2: Spare USB routed internally to another peripheral and so no plug event hook needed.

BUG=b:1603699358 BRANCH=none TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/42994/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

9:43 p.m.

Hello build bot (Jenkins), Paul Fagerburg, Paul Fagerburg,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42994

to look at the new patch set (#3).

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern

V.2: Spare USB routed internally to another peripheral and so no plug event hook needed.

BUG=b:1603699358,b:157479891 BRANCH=none TEST=none

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/42994/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

9:55 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42994 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-Comment-Date: Thu, 02 Jul 2020 04:55:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

2 Jul 2 Jul

5:04 p.m.

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42994 )

Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern ......................................................................

mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern

V.2: Spare USB routed internally to another peripheral and so no plug event hook needed.

BUG=b:1603699358,b:157479891 BRANCH=none TEST=none

Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42994 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/wyvern/overridetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/wyvern/overridetree.cb b/src/mainboard/google/hatch/variants/wyvern/overridetree.cb index 55ce5ea..c394977 100644 --- a/src/mainboard/google/hatch/variants/wyvern/overridetree.cb +++ b/src/mainboard/google/hatch/variants/wyvern/overridetree.cb @@ -81,6 +81,16 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" # Type-A Port 0 register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A Port 4

+ # Bitmap for Wake Enable on USB attach/detach + register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(6)" + register "usb3_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(5)" + # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/42994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420 Gerrit-Change-Number: 42994 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Sam McNally sammc@google.com Gerrit-MessageType: merged

1597

days inactive

1598

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Edward O'Callaghan (Code Review)
Paul Fagerburg (Code Review)
Sam McNally (Code Review)