Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76532?usp=email )
Change subject: soc/amd/genoa: Report device fabric resources to SSDT ......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/genoa/device_fabric.c:
https://review.coreboot.org/c/coreboot/+/76532/comment/354887f1_c1e198eb : PS4, Line 322: const struct { : uint8_t fabric_id; : const char *acpi_name; : } acpi_names[] = { : { 0x22, "S0B0"}, : { 0x23, "S0B1"}, : { 0x21, "S0B2"}, : { 0x20, "S0B3"}, : }; : : for (int i = 0; ARRAY_SIZE(acpi_names); i++) : if (acpi_names[i].fabric_id == dev->path.domain.domain) : return acpi_names[i].acpi_name; this code needs to be reworked, since we're using the domain numbers 0..3 and not the fabric IDs as domain numbers any more. so just have a const array with the 4 names, check if dev->path.domain.domain is < ARAY_SIZE(acpi_names) and in that case return acpi_names[dev->path.domain.domain], otherwise NULL